Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )
Change subject: vboot: refactor OPROM code ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/#/c/32262/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32262/2//COMMIT_MSG@20 PS2, Line 20: andset
and set
Done
https://review.coreboot.org/#/c/32262/2/src/lib/bootmode.c File src/lib/bootmode.c:
https://review.coreboot.org/#/c/32262/2/src/lib/bootmode.c@41 PS2, Line 41: *
Please remove the asterisk.
Done
https://review.coreboot.org/#/c/32262/2/src/lib/bootmode.c@45 PS2, Line 45: return !vboot_handoff_skip_display_init();
This return line can now be removed?
Done
https://review.coreboot.org/#/c/32262/2/src/security/vboot/vboot_handoff.c File src/security/vboot/vboot_handoff.c:
https://review.coreboot.org/#/c/32262/2/src/security/vboot/vboot_handoff.c@8... PS2, Line 80: *
Remove for concise multi-line comment.
Done