Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45037 )
Change subject: soc/intel/icelake: Select CPU_INTEL_COMMON
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45037/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45037/1//COMMIT_MSG@9
PS1, Line 9: to show the prompt for ENABLE_VMX
It also shows the prompt for SET_IA32_FC_LOCK_BIT. But it's not hooked
up. If applicable, set_feature_ctrl_lock() should be called.
This either needs more work/investigation or more fine-grained control
of the prompts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45037
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b0ca209b60f9804b8f56497046eff96da01cb5c
Gerrit-Change-Number: 45037
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Sep 2020 21:39:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment