Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29490 )
Change subject: soc/intel/common: Add SSID header ......................................................................
Patch Set 13:
Patch Set 13:
Why FSP want to program that? Cause some internal devices may not follow the same programming sequence like regular PCI devices, have an option open to let
FSP
did the programming for internal devices in case of some hacks
may
needed.
Did you ever look at `struct pci_operations`? `set_subsystem` is
a
function pointer for a reason. You can easily implement your
"hacks"
in coreboot.
Yes I did look at that, in theory the situation caused by the "lock" in FSP that make the function pointer won't be working for PCH internal devices.
Even it is not fit for this situation, there's possibility that
it
may use internal register that expose the programming into coreboot? Overall we still want to protect vendor's IP?
Yes, but not primarily. I would say the primary objective is to make customers happy. This is best done with sane, maintainable code which may conflict vendor-IP protection.
That's against the training I have got, sorry I disagree with that.