30 Dec
2020
30 Dec
'20
11:44 a.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48977 )
Change subject: util/amdfwtool: portability fixes for FreeBSD ......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48977/9/util/amdfwtool/amdfwtool.h File util/amdfwtool/amdfwtool.h:
https://review.coreboot.org/c/coreboot/+/48977/9/util/amdfwtool/amdfwtool.h@... PS9, Line 12:
WHy, for cleanliness? It builds and runs, and stdint. […]
i meant additionally, so that it's included in both the .h and the .c files. i won't insist on this, so if you think that your patch should stay the way it is, feel free to just click ack on this one
--
To view, visit https://review.coreboot.org/c/coreboot/+/48977
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I295fd308b0f5e2902931f02c9455823a614976de
Gerrit-Change-Number: 48977
Gerrit-PatchSet: 9
Gerrit-Owner: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 30 Dec 2020 19:44:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Idwer Vollering vidwer@gmail.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment