Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )
Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede...
PS6, Line 87: "280"
Referring to [1], the stop_delay_ms is in _ON power sequence so 280ms here would be correct? […]
_ON: stop_delay_ms = After stop pin high, then delay (stop_delay_ms).
_OFF: stop_off_delay_ms = stop pin low -> reset low
I think it is correct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40251
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I030c7d7e76a9705be06fe907c4ac279e247cb163
Gerrit-Change-Number: 40251
Gerrit-PatchSet: 6
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Apr 2020 01:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment