Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38090 )
Change subject: mb/hp/2570p: Transform into variant-enabled structure
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38090/2/src/mainboard/hp/snb_ivb_la...
File src/mainboard/hp/snb_ivb_laptops/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/38090/2/src/mainboard/hp/snb_ivb_la...
PS2, Line 24: select MAINBOARD_USES_IFD_GBE_REGION
Can this be moved to Kconfig?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b68e524b57e3705e91e3cd98be5571b3554bd67
Gerrit-Change-Number: 38090
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 18 Jan 2020 13:11:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment