Attention is currently required from: Hung-Te Lin, Kiwi Liu, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78801?usp=email )
Change subject: soc/mediatek/mt8188: Support loading BL32 image from rootfs ......................................................................
Patch Set 13:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78801/comment/9e3983c0_f4795156 : PS1, Line 7: optee
What does this prefix mean?
Done
https://review.coreboot.org/c/coreboot/+/78801/comment/5715c4d6_be38fb1c : PS1, Line 7: loading
Please use imperative mood: Load BL32 image from rootfs
Done
https://review.coreboot.org/c/coreboot/+/78801/comment/4f4469d4_c31821b7 : PS1, Line 9: loading of BL32 image from rootfs
Please elaborate and give the reason/motivation for the change.
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/78801/comment/2273880e_44cd6493 : PS13, Line 7: BL32 image from rootfs OP-TEE via an SMC
https://review.coreboot.org/c/coreboot/+/78801/comment/bd929b54_5ff4d11f : PS13, Line 10: BL32 image from rootfs OP-TEE via an SMC from rootfs
https://review.coreboot.org/c/coreboot/+/78801/comment/769dfdbe_12865804 : PS13, Line 11: BL32 the OP-TEE
File src/soc/mediatek/mt8188/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/78801/comment/250d37dd_0f2b8914 : PS13, Line 62: CROS_WIDEVINE_SMC Where does `CROS_WIDEVINE_SMC` come from? I can't find it in the TF-A repo.
https://review.coreboot.org/c/coreboot/+/78801/comment/f0b5218e_f83a29f8 : PS13, Line 61: PLAT=mt8188 SPD=opteed OPTEE_ALLOW_SMC_LOAD=1 \ : PLAT_XLAT_TABLES_DYNAMIC=1 CROS_WIDEVINE_SMC=1
Is there any reason that the parameters should be in the same line ?
I agree. Please rewrite as:
``` BL31_MAKEARGS += PLAT=mt8188 BL31_MAKEARGS += SPD=opteed OPTEE_ALLOW_SMC_LOAD=1 PLAT_XLAT_TABLES_DYNAMIC=1 ```