Attention is currently required from: Nick Vaccaro, Paul Menzel.
Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78310?usp=email )
Change subject: mb/google/brya/var/marasov: Enable wifi sar table for Intel module ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78310/comment/9a8b0c2a_f3e80da7 : PS3, Line 2: Daniel_Peng
Please update your git configuration to remove the underscore in the name: […]
Done
https://review.coreboot.org/c/coreboot/+/78310/comment/b039f7ee_eb79aa6b : PS3, Line 8:
Please motivate the change, by stating the problem. Maybe: […]
Done
Patchset:
PS3: Move the branch to main. Please see CL:https://review.coreboot.org/c/coreboot/+/77789.
File src/mainboard/google/brya/variants/marasov/variant.c:
https://review.coreboot.org/c/coreboot/+/78310/comment/8f12a8f7_3606617c : PS3, Line 13: printk(BIOS_INFO, "Use wifi_sar_1.hex.\n");
Info messages should be understandable to “normal” users. […]
Done
https://review.coreboot.org/c/coreboot/+/78310/comment/bd8439c3_f73d9fb4 : PS3, Line 17: printk(BIOS_INFO, "Intel Wi-Fi SAR not used, return NULL!\n");
It’d be great, if you rephrased this too.
Done. Thanks for the suggestion.