Attention is currently required from: V Sowmya, Martin Roth, Tim Wawrzynczak, Subrata Banik, Balaji Manigandan.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49732 )
Change subject: mb/intel/shadowmountain: Add the ramstage code
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c:
https://review.coreboot.org/c/coreboot/+/49732/comment/07a93f63_25386506
PS3, Line 33: /* D15 : MEM_STRAP_3 */
: PAD_CFG_GPI(GPP_D15, NONE, DEEP),
can be marked NC, only 0, 1, 2 are been used for memory straps.
File src/mainboard/intel/shadowmountain/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/49732/comment/5305e4d0_e08ebd1f
PS3, Line 164: /* E10 : PCH_GSPI0_H1_TPM_CS_L */
: PAD_CFG_NF(GPP_E10, NONE, DEEP, NF7),
: /* E11 : PCH_GSPI0_H1_TPM_CLK */
: PAD_CFG_NF(GPP_E11, NONE, DEEP, NF7),
: /* E12 : PCH_GSPIO_H1_TPM_MISO */
: PAD_CFG_NF(GPP_E12, NONE, DEEP, NF7),
: /* E13 : PCH_GSPI0_H1_TPM_MOSI_STRAP */
: PAD_CFG_NF(GPP_E13, NONE, DEEP, NF7),
can be skipped , part of early gpio table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49732
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I419eecefddf9ee6e4249ada041ebeb1b78e85eb7
Gerrit-Change-Number: 49732
Gerrit-PatchSet: 3
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Fri, 05 Feb 2021 05:24:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment