[coreboot-gerrit] [L] Change in coreboot[main]: mb/asrock: Add Z87M OC Formula (Haswell)

[Angel Pons (Code Review)]

Attention is currently required from: Felix Singer, Jan Philipp Groß, Máté Kukri, Nicholas Chin.

Angel Pons has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82906?usp=email )

Change subject: mb/asrock: Add Z87M OC Formula (Haswell)
......................................................................

Patch Set 7:

(15 comments)

File src/mainboard/asrock/z87m_oc_formula/Kconfig:

https://review.coreboot.org/c/coreboot/+/82906/comment/caca29f3_32782f80?usp... :
PS7, Line 19: 	string
Drop `string`

https://review.coreboot.org/c/coreboot/+/82906/comment/440c88e3_b2bff2a5?usp... :
PS7, Line 23: 	string
Drop `string`

https://review.coreboot.org/c/coreboot/+/82906/comment/222630be_545c6597?usp... :
PS7, Line 26: config VGA_BIOS_ID
            : 	string
            : 	default "8086,0412"
Drop the whole thing

File src/mainboard/asrock/z87m_oc_formula/acpi/ec.asl:

https://review.coreboot.org/c/coreboot/+/82906/comment/197ce236_cd01eb38?usp... :
PS7, Line 2: /* Please update the license if adding licensable material. */
```suggestion

/* Please update the license if adding licensable material. */
```

File src/mainboard/asrock/z87m_oc_formula/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/82906/comment/f0514c9d_8f2ae64c?usp... :
PS7, Line 2: /* Please update the license if adding licensable material. */
```suggestion

/* Please update the license if adding licensable material. */
```

File src/mainboard/asrock/z87m_oc_formula/devicetree.cb:

PS7: 
Align cosmetics with other board ports, e.g.: https://review.coreboot.org/c/coreboot/+/82913/4/src/mainboard/asrock/fatal1...

I'll comment further on the next iteration.

File src/mainboard/asrock/z87m_oc_formula/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/82906/comment/17a7d41f_b932ec1f?usp... :
PS7, Line 3: 
Drop one blank line

https://review.coreboot.org/c/coreboot/+/82906/comment/244f5a34_1c8aed23?usp... :
PS7, Line 12: 	0x20141018	/* OEM revision */
Please kill this with fire

```suggestion
    0x20141018
```

https://review.coreboot.org/c/coreboot/+/82906/comment/50fab41b_8aa3a299?usp... :
PS7, Line 26: /* FIXME: remove this if the board doesn't have backlight. */
            : 		#include <drivers/intel/gma/acpi/default_brightness_levels.asl>
Drop

File src/mainboard/asrock/z87m_oc_formula/gma-mainboard.ads:

https://review.coreboot.org/c/coreboot/+/82906/comment/b57b6135_8e77d1f2?usp... :
PS7, Line 11:    -- FIXME: check this
One DP output, one HDMI output. coreboot logs with libgfxinit debug enabled will show the correct ports. For DP, keep the corresponding HDMI port enabled. In the end, there should be 3 ports left.

File src/mainboard/asrock/z87m_oc_formula/hda_verb.c:

https://review.coreboot.org/c/coreboot/+/82906/comment/6189ff73_43ce35d8?usp... :
PS7, Line 20: 
Drop blank line

File src/mainboard/asrock/z87m_oc_formula/romstage.c:

https://review.coreboot.org/c/coreboot/+/82906/comment/2cfcb677_1c77bbfd?usp... :
PS7, Line 3: #include <stdint.h>
Drop

https://review.coreboot.org/c/coreboot/+/82906/comment/42b87768_fd26b2aa?usp... :
PS7, Line 12: /* FIXME: called after romstage_common, remove it if not used */
            : void mb_late_romstage_setup(void)
            : {
            : }
Drop

https://review.coreboot.org/c/coreboot/+/82906/comment/3d7ab258_96fab7e0?usp... :
PS7, Line 19: 	/* FIXME: check this */
If all 4 DIMM slots work, drop

https://review.coreboot.org/c/coreboot/+/82906/comment/96c3e941_d329f963?usp... :
PS7, Line 27: 	/* FIXME: Length and Location are computed from IOBP values, may be inaccurate */
If all USB ports work, drop