build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27665 )
Change subject: mb/pcengines/apu2: correct GPIO and LED setting ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/27665/1/src/mainboard/pcengines/apu2/gpio_ft... File src/mainboard/pcengines/apu2/gpio_ftns.c:
https://review.coreboot.org/#/c/27665/1/src/mainboard/pcengines/apu2/gpio_ft... PS1, Line 36: bdata |= (setting & (GPIO_OUTPUT_ENABLE | GPIO_OUTPUT_VALUE | GPIO_PULL_UP_ENABLE | GPIO_PULL_DOWN_ENABLE)); line over 80 characters
https://review.coreboot.org/#/c/27665/1/src/mainboard/pcengines/apu2/romstag... File src/mainboard/pcengines/apu2/romstage.c:
https://review.coreboot.org/#/c/27665/1/src/mainboard/pcengines/apu2/romstag... PS1, Line 116: if (IS_ENABLED(CONFIG_BOARD_PCENGINES_APU5)) { braces {} are not necessary for single statement blocks