build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59583 )
Change subject: amdfwtool: replace strcmp to switch-case ......................................................................
Patch Set 1:
(3 comments)
File util/amdfwtool/data_parse.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134125): https://review.coreboot.org/c/coreboot/+/59583/comment/472e1d47_2649e03a PS1, Line 176: if (strcmp(fw_name, "PSPBTLDR_WL_FILE") == 0) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134125): https://review.coreboot.org/c/coreboot/+/59583/comment/6cef2917_b842666d PS1, Line 179: return (cb_config->have_whitelist); return is not a function, parentheses are not required
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134125): https://review.coreboot.org/c/coreboot/+/59583/comment/0fa7617e_3bd451b0 PS1, Line 203: if (should_skip_entry(fw_name, fw_type, cb_config)) { braces {} are not necessary for single statement blocks