Attention is currently required from: Kevin Chiu, Furquan Shaikh, Bhanu Prakash Maiya, Paul Menzel, Eric Peers.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47857 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for dirinboz
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/47857/comment/0092a507_33adec86
PS2, Line 11: COMPDISTUNE(COMPDISTUNE0): 0x7
Where did you get these from?
Looking at the bug, these were calculated through a very lengthy process starting with a failing eye diagram. The EEs and AMD calculated the needed changes from the default values which were verified through testing.
https://review.coreboot.org/c/coreboot/+/47857/comment/f2220325_ad2cb772
PS2, Line 15: TEST=emerge-zork coreboot
How did you verify those?
The values were tested empirically with an eye diagram mf the USB signals.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I371e4295c2ee161096f0a277c0c649bf217269b2
Gerrit-Change-Number: 47857
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Comment-Date: Fri, 15 Jan 2021 22:38:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment