John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40968 )
Change subject: soc/intel/tigerlake: Disable TBT PCIe root ports bus master
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40968/13/src/drivers/intel/tbt/Kcon...
File src/drivers/intel/tbt/Kconfig:
https://review.coreboot.org/c/coreboot/+/40968/13/src/drivers/intel/tbt/Kcon...
PS13, Line 5: When enabled, chip driver/intel/tbt will add support for TBT.
Why is a separate driver needed? Isn’t there another way to hook it up automatically?
This driver can be enabled through platform configuration. i.e, add "select DRIVERS_INTEL_TBT" in mainboard/google/volteer/Kconfig.
https://review.coreboot.org/c/coreboot/+/40968/13/src/drivers/intel/tbt/tbt....
File src/drivers/intel/tbt/tbt.c:
https://review.coreboot.org/c/coreboot/+/40968/13/src/drivers/intel/tbt/tbt....
PS13, Line 12: .read_resources = pci_bus_read_resources,
: .set_resources = pci_dev_set_resources,
: .enable_resources = pci_bus_enable_resources,
: .init = tbt_pci_init,
: .scan_bus = pci_scan_bridge,
: .reset_bus = pci_bus_reset,
Please use tabs for aligning the equal sign =.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40968
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9650b9dd4df1f9bee53ae3737b7bf60b2ef8017b
Gerrit-Change-Number: 40968
Gerrit-PatchSet: 13
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Prashant Malani
pmalani@google.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.corp-partner.google.com
Gerrit-CC: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-CC: Lalithambika Krishnakumar
lalithambika.krishnakumar@intel.corp-partner.google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 24 Jun 2020 15:49:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment