Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33993 )
Change subject: mainboard/amd: Add padmelon board code ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... File src/mainboard/amd/padmelon/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 41: unsigned long write_pirq_routing_table(unsigned long addr)
Only test so far was booting to Linux.
All family 15h platforms use the very same file... might even consider making it a family 15h folder specific.... So as grunt was extensively tested and works, I should assume this file is correct.
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 79: /* pci bridge */
Maybe, need to check. Code started by Marc, I did not review some sections.
Actually code started even earlier... all family 15h use the same code.
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... File src/mainboard/amd/padmelon/mainboard.c:
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 35: * MP Tables. TODO: Make ACPI use these values too.
These are about programming the registers before loading OS, not about creating a table for the OS. […]
Seems to be correct, only extensive testing will confirm though.
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... File src/mainboard/amd/padmelon/mptable.c:
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 116: /* PCI slots */
Will check... this section of code was not created by me.
All family 15h have it, not my decision. Don't know why, might have come from earlier projects/family? As for physically, there are 2 slots only. A mini PCI-e (x1) and a GFX (x8)
https://review.coreboot.org/c/coreboot/+/33993/7/src/mainboard/amd/padmelon/... PS7, Line 143: PCI_INT(0x0, 0x15, 0x0, 0x10);
Will check
No.