build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34501 )
Change subject: Framework to get settings from RW_VPD to configure FSP UPD ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34501/4/src/drivers/vpd/vpd_fsp.c File src/drivers/vpd/vpd_fsp.c:
https://review.coreboot.org/c/coreboot/+/34501/4/src/drivers/vpd/vpd_fsp.c@1... PS4, Line 135: if (decodeLen(max_len - *consumed, suspect code indent for conditional statements (16, 32)
https://review.coreboot.org/c/coreboot/+/34501/4/src/drivers/vpd/vpd_fsp.c@1... PS4, Line 148: if (decodeLen(max_len - *consumed, suspect code indent for conditional statements (16, 32)
https://review.coreboot.org/c/coreboot/+/34501/4/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c:
https://review.coreboot.org/c/coreboot/+/34501/4/src/soc/intel/fsp_broadwell... PS4, Line 55: const char *board_upd_vars[] = {"HyperThreading"}; char * array declaration might be better as static const
https://review.coreboot.org/c/coreboot/+/34501/4/src/soc/intel/fsp_broadwell... PS4, Line 172: board_fsp_configure_upd_data, UpdData) == VPD_FAIL) line over 96 characters