[coreboot-gerrit] Change in coreboot[master]: drivers/intel/gma: Move IGD OpRegion to CBMEM

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40724 )

Change subject: drivers/intel/gma: Move IGD OpRegion to CBMEM
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40724/6/src/soc/intel/apollolake/gr... 
File src/soc/intel/apollolake/graphics.c:

https://review.coreboot.org/c/coreboot/+/40724/6/src/soc/intel/apollolake/gr... 
PS6, Line 23: uint32_t reg32 = pci_read_config32(dev, PCI_COMMAND);
            : 	reg32 |= PCI_COMMAND_MASTER;
            : 	pci_write_config32(dev, PCI_COMMAND, reg32);
> Ah, yes. I made the assumption that RUN_FSP_GOP implies that FSP already […]

it's not problematic to enable bus mastering on the FSP/GOP path, SKL does it too and no issues. restricting to non-FSP just makes the code below more complicated than it needs to be