Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40223 )
Change subject: mb/google/hatch: Add Duffy variant ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40223/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40223/1//COMMIT_MSG@8 PS1, Line 8:
Created how?
Done
https://review.coreboot.org/c/coreboot/+/40223/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/40223/3/src/mainboard/google/hatch/... PS3, Line 77: config BOARD_GOOGLE_DUFFY
alphabetize
Done
https://review.coreboot.org/c/coreboot/+/40223/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/duffy/mainboard.c:
https://review.coreboot.org/c/coreboot/+/40223/2/src/mainboard/google/hatch/... PS2, Line 15: /* TODO: This can be moved to common directory */
maybe do this first?
Done
https://review.coreboot.org/c/coreboot/+/40223/2/src/mainboard/google/hatch/... PS2, Line 57: #define PUFF_PL2 (35)
Is the plan to rename or move these "PUFF" macros?
Done