Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45336 )
Change subject: soc/intel/common/basecode: Add Intel common reset code
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45336/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45336/5//COMMIT_MSG@7
PS5, Line 7: soc/intel/common/block
without any guard, its giving compilation error saying cse_request_global_reset unknown function r […]
Also, I think `do_global_reset()` doesn't really need to be exposed out of the common/basecode/reset/reset.c It should really only be used by `global_reset()`. There is a single caller of `do_global_reset()` which is within cse_lite.c. I think that should really be calling `global_reset()` and not `do_global_reset()`.
https://review.coreboot.org/c/coreboot/+/45336/8/src/soc/intel/common/baseco...
File src/soc/intel/common/basecode/reset/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45336/8/src/soc/intel/common/baseco...
PS8, Line 4: endif
Why was postcar dropped?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45336
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icafe931ba9920501cf5448290ddd9f897760bb75
Gerrit-Change-Number: 45336
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Fri, 18 Sep 2020 18:08:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subi.banik@gmail.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment