Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48764 )
Change subject: [WIP] 3rdparty/libgfxinit: Update for Cannon Point support ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48764/1/3rdparty/libgfxinit File 3rdparty/libgfxinit:
https://review.coreboot.org/c/coreboot/+/48764/1/3rdparty/libgfxinit@1 PS1, Line 1: b9e792ee73407d
The correct hash can only be known once the libgfxinit changes are merged. […]
Ack
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 127: SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE
I'd prefer to leave this as-is on this patch, and change this instance and the one for GFX_GMA_GENER […]
let's merge as-is and revisit, when CNL got dropped
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: default "Cannon_Point" if SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
SOC_INTEL_COMETLAKE can be added now
let's merge as-is and revisit, when CNL got dropped
https://review.coreboot.org/c/coreboot/+/48764/1/src/drivers/intel/gma/Kconf... PS1, Line 128: SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
SOC_INTEL_CANNONLAKE_BASE
let's merge as-is and revisit, when CNL got dropped