Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44196 )
Change subject: mrc_cache: Update mrc_cache data in romstage
......................................................................
Patch Set 24:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_...
File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/44196/22/src/drivers/mrc_cache/mrc_...
PS22, Line 120:
nit: irrelevant change.
This was not aligned before and now it's aligned.
https://review.coreboot.org/c/coreboot/+/44196/24/src/drivers/spi/Kconfig
File src/drivers/spi/Kconfig:
https://review.coreboot.org/c/coreboot/+/44196/24/src/drivers/spi/Kconfig@45
PS24, Line 45: BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES
Addition of this Kconfig should be its own separate CL along with selecting it for platforms that ne […]
Do you just want a CL with the config and the platforms selecting it in a CL prior to the romstage writeback CL (basically a no-op)? Is it weird for platforms to be selecting a config that doesn't do anything?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3430bda45484cb8c2b01ab9614508039dfaac9a3
Gerrit-Change-Number: 44196
Gerrit-PatchSet: 24
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 25 Sep 2020 16:08:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment