Attention is currently required from: Karthik Ramasubramanian, Nick Vaccaro, Shelley Chen.
Pavan Holla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81967?usp=email )
Change subject: ec/google/chromeec: Do not fill TypeC ACPI device when UCSI is enabled. ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81967/comment/64e069db_c8524c90 : PS2, Line 7: Hide typec ACPI device if UCSI is supported
Nit: […]
Done
https://review.coreboot.org/c/coreboot/+/81967/comment/9adba526_16c751f2 : PS2, Line 9: remove
We are not removing. Rather we are not filling the TypeC ACPI device when UCSI is enabled. […]
Done
https://review.coreboot.org/c/coreboot/+/81967/comment/abf38728_56c783d6 : PS2, Line 17: b/333074788 and https://crrev.com/c/5421069 track the corresponding EC : change to add CBI. : https://crrev.com/c/5416841 is the change for adding the feature flag
These links probably are access controlled and hence the community may not have access to it. […]
Done
https://review.coreboot.org/c/coreboot/+/81967/comment/7901682a_a4cb5de9 : PS2, Line 23:
Cq-Depend: chromium:5416841
Done
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/81967/comment/1bb3afd2_d83aff60 : PS2, Line 161: /* UCSI implementations do not require an ACPI device : * with mux info since the linux kernel doesn't set : * the muxes. */
Nit: Coreboot allows 96 chars per line. […]
Done