Attention is currently required from: Karthik Ramasubramanian, Nick Vaccaro, Shelley Chen.

View Change

5 comments:

• Commit Message:

  • Patch Set #2, Line 7: Hide typec ACPI device if UCSI is supported

    Nit: […]

    Done

  • Patch Set #2, Line 9: remove

    We are not removing. Rather we are not filling the TypeC ACPI device when UCSI is enabled. […]

    Done

  • Patch Set #2, Line 17:

    b/333074788 and https://crrev.com/c/5421069 track the corresponding EC
    change to add CBI.
    https://crrev.com/c/5416841 is the change for adding the feature flag
    

    These links probably are access controlled and hence the community may not have access to it. […]

    Done

  • Patch Set #2, Line 23:

    Cq-Depend: chromium:5416841

    Done

• File src/ec/google/chromeec/ec_acpi.c:

  • Patch Set #2, Line 161:

    /* UCSI implementations do not require an ACPI device
    	 * with mux info since the linux kernel doesn't set
    	 * the muxes. */
    

    Nit: Coreboot allows 96 chars per line. […]

    Done

To view, visit change 81967. To unsubscribe, or for help writing mail filters, visit settings.