Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32020 )
Change subject: [WIP]x86: Introduce the blobolator
......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
libx86emu seems to be similar to x86emu. Should the libx86emu vendorcode be deduplicated src/device/oprom/x86emu and src/device/oprom/include/x86emu?
I couldn't find the original x86emu any more. It looks like libx86emu is the successor to x86emu.
The original is somewhere deep in the XFree86 (and likely Xorg) tree. We can use libx86emu, but we shouldn't keep two copies in our tree is all I'm saying.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32020
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13e47f45e69376d046f35c04363fe3db1cfaa610
Gerrit-Change-Number: 32020
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Fri, 22 Mar 2019 10:23:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment