Attention is currently required from: Hung-Te Lin, Vince Liu, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/86538?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/mediatek/mt8189: Reduce bootblock size by separating SPI NOR GPIOs
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86538/comment/912d2548_cede962f?usp... :
PS2, Line 12: This modification reduces the bootblock code size by 1KB.
Please either
1. do not start a new line, or
2. start a new paragraph
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86538?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If7e8e5c7db59b5f181db14f6e66df2f333dbb6d4
Gerrit-Change-Number: 86538
Gerrit-PatchSet: 2
Gerrit-Owner: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Thu, 20 Feb 2025 09:52:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes