Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49016 )
Change subject: device: Select VGA_ROM_RUN for non-FSP solution with PCIE DGPU ......................................................................
Patch Set 5:
(8 comments)
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@9 PS4, Line 9: For onboard graphics initialization
It’d be great, if you could be more specific to add, it’s about graphics in the payload (or OS witho […]
Ack
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@14 PS4, Line 14: platform need to
needs
Ack
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@14 PS4, Line 14: In case of non-FSP solution, platform need to select VGA_ROM_RUN : Kconfig to perform graphics initialization for PCI-E based discrete : card through VGA OpRom (SoC or Mainboard user can't select VGA_ROM_RUN : directly because it's part of choice option).
Some payloads, like SeaBIOS, are also able to run Option ROMs, so coreboot does not need to (and sho […]
Ack
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@22 PS4, Line 22: updated
update
Ack
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@25 PS4, Line 25: PCI-E DGPU
As coreboot sometimes has problems executing Option ROMs, please say exactly which card and what Vid […]
Ack
https://review.coreboot.org/c/coreboot/+/49016/4//COMMIT_MSG@26 PS4, Line 26: select
selects
Ack
https://review.coreboot.org/c/coreboot/+/49016/4/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/49016/4/src/device/Kconfig@53 PS4, Line 53: discrete graphics card
Is it really only related to discrete graphics cards?
got your point, this could be both discrete and onboard GFX, but do ppl really use oprom days for onboard GFX i mean integrated GFX, The purpose of this CL is to ensure VGA_ROM_RUN can run default when it need the most.
Do you suggest to remove "discrete" work explicitly and cover a case where oprom can be use for integrated gfx as well ? i believe for other case we already have VGA_BIOS Kconfig hence this is only for DGPU.
https://review.coreboot.org/c/coreboot/+/49016/4/src/device/Kconfig@53 PS4, Line 53: need
needs
Ack