Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31486 )
Change subject: soc/amd/common: Refactor AmdCreateStruct() use ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/31486/5/src/soc/amd/common/block/pi/agesawra... File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/31486/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 68: aip Why aip? Initial name, interface_struct, was descriptive (though long), I can't figure out why aip.
https://review.coreboot.org/#/c/31486/5/src/soc/amd/common/block/pi/agesawra... PS5, Line 111: return module_dispatch(AMD_RELEASE_STRUCT, &aip->StdHeader); Original code replaced AGESA_BOUNDS_CHK with AGESA_UNSUPPORTED. However, a bounds check means that there's no create_struct/release_struct for the particular function, so it would already have failed to create the structure and, and would die at AMD_INIT_EARLY. This is going out of AMD initial intention, but I don't think it's harmful.