Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35014 )
Change subject: Move and rename ARCH_STAGE_HAS_xxx_SECTION rules ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h@277 PS5, Line 277: sometimes SRAM not DRAM Doesn't this comment apply only to PRE_RAM stages?
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h@278 PS5, Line 278: #define ENV_STAGE_HAS_DATA_SECTION 1 : #define ENV_STAGE_HAS_BSS_SECTION 1 Can these be moved out of #if .. #else .. #endif and defined as !ENV_CACHE_AS_RAM always?
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h@288 PS5, Line 288: he reason : * post-CAR utilizes __SIMPLE_DEVICE__ is for simplicity. Currently there's : * no known requirement that devicetree would be needed during that stage. Not for this change, but this comment needs an update. Introduction of ENV_PAYLOAD_LOADER has changed the behavior here if post-CAR is the payload loader.
https://review.coreboot.org/c/coreboot/+/35014/5/src/include/rules.h@297 PS5, Line 297: defined(__PRE_RAM__) Should this be updated to ENV_CACHE_AS_RAM as well may be in a follow-up CL?