14 Sep
2020
14 Sep
'20
3:26 p.m.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40322 )
Change subject: soc/amd/picasso: Clean up legacy UART config ......................................................................
Patch Set 7:
Patch Set 7:
the remaining thing I'm not sure about is if the ACPI entries for the MMIO UARTs should be hidden when PICASSO_UART_LEGACY is set, so that the same UARTs won't get exposed to the OS twice. If a SoC serial port is used as console, it'll still use the MMIO interface, but that is no issue there
I suspect resources should become reserved instead of part of an AMD0020 device. Existing content LGTM.
--
To view, visit https://review.coreboot.org/c/coreboot/+/40322
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id08ff6428d4019303ebb6e44e13aba480cf1fde2
Gerrit-Change-Number: 40322
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Sep 2020 22:26:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment