William Wei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42677 )
Change subject: soc/intel/tigerlake: Run pmc_set_acpi_mode() during .init in pmc_ops
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42677/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42677/5//COMMIT_MSG@9
PS5, Line 9: deal
Past tense: dealt?
Done
https://review.coreboot.org/c/coreboot/+/42677/5//COMMIT_MSG@11
PS5, Line 11: will fail.)
Please add the dot/period after the ).
Done
https://review.coreboot.org/c/coreboot/+/42677/5/src/soc/intel/tigerlake/pmc...
File src/soc/intel/tigerlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/42677/5/src/soc/intel/tigerlake/pmc...
PS5, Line 146: PMC initialization happens earlier for this SoC
Subrata, I should have added you to the reviews for https://review.coreboot. […]
Many thanks, I've updated them to patchset 6.
https://review.coreboot.org/c/coreboot/+/42677/5/src/soc/intel/tigerlake/pmc...
PS5, Line 158: P.S.: This cannot be done as part of pmc_soc_init as PMC device is
: * hidden and hence the PMC driver never gets enumerated and so init is
: * not called for it.
suggested rewrite above.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfff5cc5550f23938343e4d26ef76093bb9cf7c3
Gerrit-Change-Number: 42677
Gerrit-PatchSet: 6
Gerrit-Owner: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Usha P
usha.p@intel.com
Gerrit-CC: Xiong Huang
xiong.huang@bitland.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Sun, 28 Jun 2020 02:57:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: William Wei
wenxu.wei@bitland.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment