[coreboot-gerrit] Change in ...coreboot[master]: mainboard/facebook/fbg1701: Do initial mainboard commit

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30414 )

Change subject: mainboard/facebook/fbg1701: Do initial mainboard commit
......................................................................

Patch Set 23:

(2 comments)

New patch set will be uploaded solving latest comments

https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmos... 
File src/mainboard/facebook/fbg1701/cmos.layout:

https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmos... 
PS23, Line 69: 4
> Overflows quickly, please state in a comment when it's OK.

Use by core, not by platform. Expect that 'h' is covering this.
To be save, will add comment for this.

https://review.coreboot.org/#/c/30414/23/src/mainboard/facebook/fbg1701/cmos... 
PS23, Line 91: 896         32        r       0        mrc_scrambler_seed
             : 928         32        r       0        mrc_scrambler_seed_s3
> Not check-summed, state in a comment when it's by design or adjust the range.

Result of copy/paste from Intel Stago. Values not used on Braswell