[coreboot-gerrit] Change in coreboot[master]: soc/skylake/vr_config: Add VR config for Skylake S

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35167 )

Change subject: soc/skylake/vr_config: Add VR config for Skylake S
......................................................................

Patch Set 2:

(1 comment)

Maybe making a table (2D array) with the IccMax values would be better to avoid confusion

https://review.coreboot.org/c/coreboot/+/35167/2/src/soc/intel/skylake/vr_co... 
File src/soc/intel/skylake/vr_config.c:

https://review.coreboot.org/c/coreboot/+/35167/2/src/soc/intel/skylake/vr_co... 
PS2, Line 176: else if (tdp >= 45)
             : 			icc_max[VR_IA_CORE] = VR_CFG_AMP(70);
GT_UNSLICED and GT_SLICED don't get the IccMax of 35A configured, which they should according to the table above