Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40538 )
Change subject: tests: Add lib/string-test test case ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40538/1/tests/lib/string-test.c File tests/lib/string-test.c:
https://review.coreboot.org/c/coreboot/+/40538/1/tests/lib/string-test.c@22 PS1, Line 22: strlen
I wasn't aware that libc marks its symbols weak (and I'm not sure that this is the case everywhere). […]
I don't think the libc definitions actually are weak. It's just normal linker behavior to first look in the objects directly specified on the command line and then look in libraries for any symbols it didn't find there yet (and it doesn't complain about duplicates in libraries). The vboot test framework is also based on that principle.
I think as long as someone once (manually) made sure that this works as intended, we don't need to check anything extra in to keep retesting it, or build a lot of extra support in the framework to support symbol renaming. We don't have that many libc functions anyway, I don't think this will be a big problem in the long run.