Attention is currently required from: Elyes Haouas.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80447?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: device/pciexp_device: Use 'PCI_BASE_ADDRESS_x' macros ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/80447/comment/6ddb1987_b7475d77 : PS1, Line 711: PCI_BASE_ADDRESS_0 It's not a real PCI device, therefore noop_set_resources is used. The number for the resources used has no meaning (they don't refer to PCI config registers like real PCI device), and could have been 0, 1, 2 (in fact that's preferable to faking PCI BARs IMO). As a matter of fact it wouldn't even work if it were a real PCI device as the prefetch BAR needs an 8 byte BAR, not 4.
Using these macros is even more misleading than the raw numbers IMO.