Attention is currently required from: Elyes Haouas.

Patch set 1:Code-Review -1

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

View Change

1 comment:

• File src/device/pciexp_device.c:

  • Patch Set #1, Line 711: PCI_BASE_ADDRESS_0

    It's not a real PCI device, therefore noop_set_resources is used. The number for the resources used has no meaning (they don't refer to PCI config registers like real PCI device), and could have been 0, 1, 2 (in fact that's preferable to faking PCI BARs IMO). As a matter of fact it wouldn't even work if it were a real PCI device as the prefetch BAR needs an 8 byte BAR, not 4.

    Using these macros is even more misleading than the raw numbers IMO.

To view, visit change 80447. To unsubscribe, or for help writing mail filters, visit settings.