Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31657 )
Change subject: libpayload: keyboard: Add option to ignore failures during init
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31657/1/payloads/libpayload/Kconfig
File payloads/libpayload/Kconfig:
https://review.coreboot.org/#/c/31657/1/payloads/libpayload/Kconfig@347
PS1, Line 347: F
Should this be named PC_KEYBOARD_IGNORE_INIT_FAILURE to make it clear that it is just ignoring the init failures? If it feels like its getting too big, we can go with this too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31657
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc6053f99804f1b57d785cb04235b5c4b8d5426f
Gerrit-Change-Number: 31657
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Mar 2019 03:14:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment