Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33782 )
Change subject: vbe.h: Convert hardcode vega mode into macro ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33782/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33782/1//COMMIT_MSG@12 PS1, Line 12: Also make use of __packed to align data access.
why is this needed and what are you trying to align?
without __packed being specified below changes won't be able to get correct video_mode_ptr of starting video_mode_list[0] https://review.coreboot.org/c/coreboot/+/33737/6/src/device/oprom/realmode/x... line 253
info.video_mode_list[0]