Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37667 )
Change subject: libpayload: Implement reading from CBMEM console ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37667/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/37667/2/payloads/libpayload/drivers... PS2, Line 79: cbmem_console_read
Does it make more sense with […]
I like the idea of simplifying param type, but we also have to make the function name very clear about that caller must free the returned buffer.
What about
char *cbmem_snapshot_console(void);
That it's very clear this is a snapshot of console messages (which implies this is an extra buffer not sharing real console).
https://review.coreboot.org/c/coreboot/+/37667/2/payloads/libpayload/drivers... PS2, Line 79: size_t
I just want to be consistent with cbmem_console_write().
Well let's remove the count.
https://review.coreboot.org/c/coreboot/+/37667/2/payloads/libpayload/drivers... PS2, Line 107: corrupt
How about treating this the same as other errors?
Ack