Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31885 )
Change subject: ec/google/chromeec: Update ec_commands.h ......................................................................
Patch Set 6:
(6 comments)
https://review.coreboot.org/c/coreboot/+/31885/2/src/ec/google/chromeec/comp... File src/ec/google/chromeec/compile_time_macros.h:
https://review.coreboot.org/c/coreboot/+/31885/2/src/ec/google/chromeec/comp... PS2, Line 36: ## line
why not __COUNTER__? https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros. […]
This file is removed in the next patchset.
https://review.coreboot.org/c/coreboot/+/31885/2/src/ec/google/chromeec/comp... PS2, Line 39: BUILD_ASSERT
or _Static_assert (https://en.wikichip. […]
Ack
https://review.coreboot.org/c/coreboot/+/31885/2/src/ec/google/chromeec/comp... PS2, Line 42: run time
How is run time behavior affected by -Werror=div-by-zero?
Ack
https://review.coreboot.org/c/coreboot/+/31885/2/src/ec/google/chromeec/comp... PS2, Line 48: ARRAY_SIZE
already defined in src/commonlib/include/commonlib/helpers. […]
Ack
https://review.coreboot.org/c/coreboot/+/31885/2/src/ec/google/chromeec/comp... PS2, Line 57: offsetof
again, we already have a copy in helpers. […]
Ack
https://review.coreboot.org/c/coreboot/+/31885/2/src/ec/google/chromeec/comp... PS2, Line 61: member_size
and again.
Ack