Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38832 )
Change subject: Documentation/ifdtool: modify IFD regions ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... File Documentation/ifdtool/layout.md:
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... PS1, Line 37: It is possible to adjust the IFD regions on a firmware image or on a Flash Descriptor file directly. limit line length to 72chars
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... PS1, Line 45: Reduce Reducing
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... PS1, Line 47: ##### Step 1 - Dump IFD regions into a flashrom layout file needs more details. What is descriptor.bin? Is it a 4KiB file containing only the descriptor?
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... PS1, Line 48: $ ifdtool -f ifd_old.layout descriptor.bin encapsulate with ```bash ifdtool ... ```
https://review.coreboot.org/c/coreboot/+/38832/1/Documentation/ifdtool/layou... PS1, Line 57: ##### Step 2 - Modify the layout file This should go more into detail. What are xxxx:yyyy ?
You need to decrease yyyy of me and xxx of bios.
Alignment of regions should be 4K. Better power of two.