Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37177 )
Change subject: sb/amd/{agesa,pi}/hudson: enable support for AMD common ACPIMMIO blocks ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
(4 comments)
We want to coordinate this with AMD/SilverBack/Google such that soc/amd/common and SOC_AMD_COMMON are usable without copy-pasting headers under southbridge/hudson .
Ohh I see. Could let me know first how I should proceed with this. From your other comments I understood to reuse as much as possible form stoney SoC and work on BIOSRAM for binaryPI.
If there is a concept in soc/amd/stoneyridge or soc/amd/common that would work for binaryPI and AGESA we should use it. The approach with SOC_AMD_COMMON looks good, we just got to get co-operation and assume Silverback wants to have some ownership of amd/stoneyridge.
I am not so happy how amdblock/acpmmio.h and soc/iomap.h play together, and the guards in acpimmio/mmio_util.c. Preferably common code would not include per-platform headerfiles.
As for BIOSRAM, continue with it for APU2 bootblock.