Attention is currently required from: Eran Mitrani, Kapil Porwal, Shelley Chen, Subrata Banik, Tarun.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78244?usp=email )
Change subject: soc/intel/mtl: Display Sign-of-Life message using FSP-M ......................................................................
Patch Set 14:
(4 comments)
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/78244/comment/0f581783_4527d8bf : PS12, Line 458: SOC_INTEL_METEORLAKE_SIGN_OF_LIFE
this should be somewhere in the common code as we are planning to use this feature now onwards for a […]
As discussed earlier today, I suggest to keep as-is for now and move it to common once code once we know it really becomes common code.
File src/soc/intel/meteorlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/78244/comment/71666461_291081e5 : PS12, Line 468: 1
use the same log as GFX PEIM […]
Done.
https://review.coreboot.org/c/coreboot/+/78244/comment/5600ec49_7dad78bb : PS12, Line 469: VgaMessage
the text alignment logic is part of FSP-M code I assume ?
Correct and this is not configurable at the moment.
https://review.coreboot.org/c/coreboot/+/78244/comment/101b936f_d8a5025a : PS12, Line 497: fill_fspm_sign_of_life
Done