30 Jan
2020
30 Jan
'20
1:06 p.m.
Dennis Witzig has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38650 )
Change subject: lenovo/t440p: fix keyboard backlight ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
When changing it to "Keyboard" manually, it builds successful and the backlight works again on my T440p. Deactivating it with nvramtool also works.
https://review.coreboot.org/c/coreboot/+/38650/1/src/mainboard/lenovo/t440p/... File src/mainboard/lenovo/t440p/cmos.layout:
https://review.coreboot.org/c/coreboot/+/38650/1/src/mainboard/lenovo/t440p/... PS1, Line 107: Both cmos.default is still set to "Both" which gives an error while building because it now doesn't exist anymore
--
To view, visit https://review.coreboot.org/c/coreboot/+/38650
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4c2b1591d26e2bb33f9549e3933efe9a6e0b043
Gerrit-Change-Number: 38650
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Dennis Witzig dennis@wtzg.de
Gerrit-Reviewer: Iru Cai (vimacs) mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai mytbk920423@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jan 2020 12:06:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment