Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jeremy Soller, Kapil Porwal, Tarun, Tim Crawford.
Subrata Banik has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82730?usp=email )
Change subject: soc/intel/meteorlake: Enable USB2 port reset message on Type-C ports
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/meteorlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/82730/comment/b0ff8816_a11fbfca?usp... :
PS2, Line 481: s_cfg->PortResetMessageEnable[i] = 1
WDYT?
```
s_cfg->PortResetMessageEnable[i] = config->usb2_ports[i].type_c;
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82730?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac702a8d8edd2b3b7e03abcac020be7e45335821
Gerrit-Change-Number: 82730
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Sat, 01 Jun 2024 07:14:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No