Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33422 )
Change subject: util/inteltool: Clean up PCI assignment
......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33422/14/util/inteltool/inteltool.c
File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/33422/14/util/inteltool/inteltool.c...
PS14, Line 710: if (dev->bus != 0) continue;
Missing line break;
https://review.coreboot.org/c/coreboot/+/33422/14/util/inteltool/inteltool.c...
PS14, Line 714: if (!newdev) continue;
Do we really need this? I think this is useless here.
See documentation of pci_get_dev().
Also, missing line break.
https://review.coreboot.org/c/coreboot/+/33422/14/util/inteltool/inteltool.c...
PS14, Line 741: free
pci_free_dev()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33422
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb0c6953aee1ace275206fa4a2c16fa477bad5ec
Gerrit-Change-Number: 33422
Gerrit-PatchSet: 14
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Marius Genheimer
mail@f0wl.cc
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 30 Oct 2019 21:01:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment