Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45115 )
Change subject: soc/amd/picasso: Assign IOAPIC IDs, GNB APIC base with FSP ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45115/1/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/45115/1/src/soc/amd/picasso/Kconfig... PS1, Line 246: PICASSO_IOAPIC_IDS
Also, the new Kconfigs should be used in agesa_acpi.c: https://review.coreboot.org/cgit/coreboot. […]
Done. FWIW I'm not thrilled with assigning unrelated default values to each but AFAIK you can't do Kconfig math with the defaults. Hmm, it could be macro-ized perhaps.