Matt Delco has posted comments on this change. ( https://review.coreboot.org/28073 )
Change subject: mainboard/google/nocturne: turn off cams in D3 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28073/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/28073/1//COMMIT_MSG@9 PS1, Line 9: This means that we're : telling the OS that the cams need power in both D0 and D3 (and not the : intermediate states)
I don't think that's how OSPM to determine the power needed or not in D3 state. […]
My understanding is that the _PR3 means the devices will have power in D3hot.
Prior to this change the device would have power in D0 and D3hot, but not D1, D2, or D3cold. After this change only D0 will have power. All the cam devices I can find outside of coreboot have a _PR0 but not a _PR3. It seems more appropriate to remove the _PR3 than add a _PR2 (and probably also a "Name(_S0W, 4)" to make Windows think it's okay to transition the device to D3cold).