Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: google/kukui: Load calibration params and run DRAM calibration flow ......................................................................
Patch Set 10:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 41: if (ret == length) : return true; : else : return false; return ret == length;
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 53: BIOS_ERR BIOS_INFO?
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 53: %s with ret(0x%lx), length:0x%lx\n %s: ret=%#lx, length=%#lx\n
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 55: if (ret == length) : return true; : else : return false; return ret == length
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 73: BIOS_ERR BIOS_INFO ?
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 75: if (ret == length) : return true; : else : return false; return ret == length
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 80: true true or false?
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 144: remove the extra blank line