Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32236 )
Change subject: Documentation: Add MSI MS-7707 ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/#/c/32236/3/Documentation/mainboard/index.md File Documentation/mainboard/index.md:
https://review.coreboot.org/#/c/32236/3/Documentation/mainboard/index.md@61 PS3, Line 61: - [MSI MS-7707](msi/ms7707/ms7707.md) place under MSI, not Lenovo
https://review.coreboot.org/#/c/32236/3/Documentation/mainboard/msi/ms7707/m... File Documentation/mainboard/msi/ms7707/ms7707.md:
https://review.coreboot.org/#/c/32236/3/Documentation/mainboard/msi/ms7707/m... PS3, Line 39: * The standard method is to only flash the 2MiB BIOS region. In that case you don't need to extract blobs from vendor firmware. If you want to flash the whole chip (e.g. to disable ME) you need blobs when building coreboot. Blobs can be extracted with util/ifdtool from 4MiB full dump image (see below). I recommend to include the VGA BIOS as well (4MiB write only). Kconfig is prepared already if it gets enabled (path and 8086,0102). limit to 80chars per line
https://review.coreboot.org/#/c/32236/3/Documentation/mainboard/msi/ms7707/m... PS3, Line 47: ```eval_rst no need for that much rst, documentation should be written in markdown
https://review.coreboot.org/#/c/32236/3/Documentation/mainboard/msi/ms7707/m... PS3, Line 67: * After successful flashing turn main power off, wait some seconds to drain the capacitors, pull the battery and set the JBAT (clrcmos) jumper for some seconds. Setting the jumper alone is not enough (the Fintek is VBAT backed). Put all back in place and restart the board. It might need 1-2 AC power cycles to reinitialize (running at full fan speed - don't panic). Do you flash with main power applied? Are you able to flash without main power?
https://review.coreboot.org/#/c/32236/3/Documentation/mainboard/msi/ms7707/m... PS3, Line 73:  does it have a protection diode not powering the southbridge? see https://doc.coreboot.org/flash_tutorial/no_ext_power.html
Please reference one of the recommended flashing methods in flash_tutorial/