build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34778 )
Change subject: soc/mediatek: Change DSI init commands to take flexible length array
......................................................................
Patch Set 23:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34778/23/src/mainboard/google/kukui...
File src/mainboard/google/kukui/panel.h:
https://review.coreboot.org/c/coreboot/+/34778/23/src/mainboard/google/kukui...
PS23, Line 32: #define INIT_DCS_CMD(...) \
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/34778/23/src/mainboard/google/kukui...
PS23, Line 37: #define INIT_GENERIC_CMD(...) \
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/34778/23/src/mainboard/google/kukui...
PS23, Line 42: #define INIT_DELAY_CMD(delay) \
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34778
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I359dde8e6f2e1c0983f4677193bb47a7ae497ca6
Gerrit-Change-Number: 34778
Gerrit-PatchSet: 23
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 15 Aug 2019 00:18:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment